Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename RPC_ENDPOINT to PD_GRPC_BIND_ADDRESS #1

Merged
merged 1 commit into from
Jul 5, 2024
Merged

rename RPC_ENDPOINT to PD_GRPC_BIND_ADDRESS #1

merged 1 commit into from
Jul 5, 2024

Conversation

danbryan
Copy link
Contributor

@danbryan danbryan commented Jul 5, 2024

This should be using the --grpc-bind address from pd, not to be confused with the rpc_laddr from cometbft

@plaidfinch
Copy link
Collaborator

Thanks for the patch!

@plaidfinch plaidfinch merged commit f63fe75 into starlingcyber:main Jul 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danbryan @plaidfinch