-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_preprocessed_column
api.
#867
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #867 +/- ##
==========================================
- Coverage 91.91% 91.90% -0.01%
==========================================
Files 92 92
Lines 12599 12604 +5
Branches 12599 12604 +5
==========================================
+ Hits 11580 11584 +4
- Misses 909 910 +1
Partials 110 110 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: ed87f62 | Previous: f6214d1 | Ratio |
---|---|---|---|
merkle throughput/simd merkle |
30281991 ns/iter (± 515705 ) |
14690867 ns/iter (± 434150 ) |
2.06 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
crates/prover/src/constraint_framework/preprocessed_columns.rs
line 10 at r1 (raw file):
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] pub enum PreprocessedColumn {
I think it should be defined outside the constraint framework, maybe even in a separate crate when its defined by the air infra
but it's fine for now, add a todo?
ed87f62
to
0bed209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, all discussions resolved (waiting on @ohad-starkware)
crates/prover/src/constraint_framework/preprocessed_columns.rs
line 10 at r1 (raw file):
Previously, ohad-starkware (Ohad) wrote…
I think it should be defined outside the constraint framework, maybe even in a separate crate when its defined by the air infra
but it's fine for now, add a todo?
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
crates/prover/src/constraint_framework/preprocessed_columns.rs
line 10 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
done
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
No description provided.