Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_preprocessed_column api. #867

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

ilyalesokhin-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.90%. Comparing base (feb141a) to head (0bed209).

Files with missing lines Patch % Lines
...r/src/constraint_framework/preprocessed_columns.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #867      +/-   ##
==========================================
- Coverage   91.91%   91.90%   -0.01%     
==========================================
  Files          92       92              
  Lines       12599    12604       +5     
  Branches    12599    12604       +5     
==========================================
+ Hits        11580    11584       +4     
- Misses        909      910       +1     
  Partials      110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: ed87f62 Previous: f6214d1 Ratio
merkle throughput/simd merkle 30281991 ns/iter (± 515705) 14690867 ns/iter (± 434150) 2.06

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)


crates/prover/src/constraint_framework/preprocessed_columns.rs line 10 at r1 (raw file):

#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub enum PreprocessedColumn {

I think it should be defined outside the constraint framework, maybe even in a separate crate when its defined by the air infra
but it's fine for now, add a todo?

Copy link
Collaborator Author

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, all discussions resolved (waiting on @ohad-starkware)


crates/prover/src/constraint_framework/preprocessed_columns.rs line 10 at r1 (raw file):

Previously, ohad-starkware (Ohad) wrote…

I think it should be defined outside the constraint framework, maybe even in a separate crate when its defined by the air infra
but it's fine for now, add a todo?

done

Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)


crates/prover/src/constraint_framework/preprocessed_columns.rs line 10 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

done

nice

Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 7 of 8 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@ilyalesokhin-starkware ilyalesokhin-starkware merged commit 8c8b744 into dev Nov 5, 2024
17 of 18 checks passed
@ilyalesokhin-starkware ilyalesokhin-starkware deleted the ilya/prepro_api branch November 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants