chore(infra): remove duplication of get_available_socket #2235
+7
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
==========================================
- Coverage 40.10% 34.16% -5.94%
==========================================
Files 26 271 +245
Lines 1895 31220 +29325
Branches 1895 31220 +29325
==========================================
+ Hits 760 10667 +9907
- Misses 1100 19567 +18467
- Partials 35 986 +951 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Itay-Tsabary-Starkware
force-pushed
the
spr/main/011da994
branch
from
dceeba7
to
eba6cbb
Compare
nadin-Starkware
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
commit-id:a7620717
commit-id:011da994
Itay-Tsabary-Starkware
force-pushed
the
spr/main/a7620717
branch
from
e124d6a
to
1a1e227
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/011da994
branch
from
eba6cbb
to
e21b9bd
Compare
Open
Itay-Tsabary-Starkware
changed the base branch from
spr/main/a7620717
to
main
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-id:011da994
Stack: