-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(consensus): better debug info in case of network failure #1885
Conversation
Artifacts upload triggered. View details here |
8bf17c0
to
127a68c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
- Coverage 40.10% 31.40% -8.71%
==========================================
Files 26 3 -23
Lines 1895 242 -1653
Branches 1895 242 -1653
==========================================
- Hits 760 76 -684
+ Misses 1100 159 -941
+ Partials 35 7 -28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
crates/consensus_manager/src/consensus_manager.rs
line 80 at r1 (raw file):
Err(err) => panic!("Consensus network failed to execute to completion: {err}"), } }
Whatever you prefer, just another option
Suggestion:
network_result = &mut network_handle => {
panic!("Consensus' network task finished unexpectedly: {:?}", network_result);
}
127a68c
to
6fb5ec1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)
No description provided.