Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(consensus): better debug info in case of network failure #1885

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dan-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Nov 7, 2024

Artifacts upload triggered. View details here

@dan-starkware dan-starkware changed the title Dan/consensus/debug msg chore(consensus): better debug info in case of network failure Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.40%. Comparing base (e3165c4) to head (6fb5ec1).
Report is 243 commits behind head on main.

Files with missing lines Patch % Lines
crates/consensus_manager/src/consensus_manager.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
- Coverage   40.10%   31.40%   -8.71%     
==========================================
  Files          26        3      -23     
  Lines        1895      242    -1653     
  Branches     1895      242    -1653     
==========================================
- Hits          760       76     -684     
+ Misses       1100      159     -941     
+ Partials       35        7      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)


crates/consensus_manager/src/consensus_manager.rs line 80 at r1 (raw file):

                    Err(err) => panic!("Consensus network failed to execute to completion: {err}"),
                }
            }

Whatever you prefer, just another option

Suggestion:

            network_result = &mut network_handle => {
                panic!("Consensus' network task finished unexpectedly: {:?}", network_result);
            }

Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@dan-starkware dan-starkware merged commit 8760529 into main Nov 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants