refactor(blockifier): change return type of invoke_tx deploy_account_tx to account_transaction #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tx to account_transaction
|
This change is |
|
Artifacts upload triggered. View details here |
avivg-starkware
force-pushed
the
avivg/blockifier/impl_into_accounttx
branch
from
eba5bdd
to
309672f
Compare
|
Artifacts upload triggered. View details here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## avivg/blockifier/change_invoke_deploy_return_accounttx #1868 +/- ##
==========================================================================================
+ Coverage 67.62% 67.64% +0.01%
==========================================================================================
Files 102 102
Lines 13791 13802 +11
Branches 13791 13802 +11
==========================================================================================
+ Hits 9326 9336 +10
- Misses 4064 4065 +1
Partials 401 401 ☔ View full report in Codecov by Sentry. |
avivg-starkware
requested review from
ArniStarkware,
meship-starkware and
noaov1
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware and @noaov1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tx to account_transaction