-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add lints to p2p-sync #1844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
crates/papyrus_p2p_sync/src/server/utils.rs
line 14 at r1 (raw file):
Direction::Backward => -1, }; // TODO(shahak): Fix this code.
Kept this, negative block number still probably needs fixing 😅
Code quote:
// TODO(shahak): Fix this code.
5066da1
to
fe47725
Compare
6aa7fe3
to
d269f9f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
===========================================
- Coverage 40.10% 18.50% -21.61%
===========================================
Files 26 100 +74
Lines 1895 12218 +10323
Branches 1895 12218 +10323
===========================================
+ Hits 760 2261 +1501
- Misses 1100 9528 +8428
- Partials 35 429 +394 ☔ View full report in Codecov by Sentry. |
fe47725
to
0c14542
Compare
d269f9f
to
2b71c91
Compare
0c14542
to
82f9571
Compare
82f9571
to
620ad09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul)
Add workspace lints, which in particular ban `as` usage. Changes: 1. switch `as` into `From` when applicable. 2. replace the conditional+cast with _equivalent_ logic `u64::try_from`.
2b71c91
to
f9922df
Compare
Add workspace lints, which in particular ban
as
usage.Changes:
as
intoFrom
when applicable.u64::try_from
.