Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add target in fmt layer #1806

Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: add target in fmt layer #1806

merged 1 commit into from
Nov 5, 2024

Conversation

dan-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.89%. Comparing base (e3165c4) to head (b42d17c).
Report is 210 commits behind head on main.

Files with missing lines Patch % Lines
crates/mempool_infra/src/trace_util.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1806       +/-   ##
==========================================
- Coverage   40.10%   3.89%   -36.21%     
==========================================
  Files          26     107       +81     
  Lines        1895   13549    +11654     
  Branches     1895   13549    +11654     
==========================================
- Hits          760     528      -232     
- Misses       1100   12991    +11891     
+ Partials       35      30        -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

Copy link
Collaborator Author

dan-starkware commented Nov 5, 2024

Merge activity

  • Nov 5, 10:10 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 5, 10:12 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 5, 10:25 AM EST: A user merged this pull request with Graphite.

@dan-starkware dan-starkware changed the base branch from dan/p2p/fix_util to graphite-base/1806 November 5, 2024 15:10
@dan-starkware dan-starkware changed the base branch from graphite-base/1806 to main November 5, 2024 15:10
@dan-starkware dan-starkware merged commit e7becf2 into main Nov 5, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants