Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused convertor #1801

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review November 4, 2024 15:38
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.63%. Comparing base (e3165c4) to head (b84fb23).
Report is 228 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1801       +/-   ##
===========================================
+ Coverage   40.10%   50.63%   +10.52%     
===========================================
  Files          26       25        -1     
  Lines        1895     2534      +639     
  Branches     1895     2534      +639     
===========================================
+ Hits          760     1283      +523     
- Misses       1100     1186       +86     
- Partials       35       65       +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware merged commit ac61aae into main Nov 7, 2024
13 checks passed
@ArniStarkware ArniStarkware deleted the arni/executable_tx/remove_unused_convertor branch November 7, 2024 08:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants