Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mempool_p2p): pass broadcasted message metadata to gateway #1795

Merged

Conversation

AlonLStarkWare
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Nov 4, 2024

This change is Reviewable

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.91%. Comparing base (e3165c4) to head (7db5081).
Report is 230 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1795       +/-   ##
==========================================
- Coverage   40.10%   3.91%   -36.19%     
==========================================
  Files          26     204      +178     
  Lines        1895   26888    +24993     
  Branches     1895   26888    +24993     
==========================================
+ Hits          760    1053      +293     
- Misses       1100   25751    +24651     
- Partials       35      84       +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@AlonLStarkWare AlonLStarkWare merged commit 6890308 into main Nov 7, 2024
10 checks passed
@AlonLStarkWare AlonLStarkWare deleted the alonl/pass_broadcasted_message_metadata_to_gateway branch November 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants