Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS: Move find_methods_for_type from ide to lang::inspect #6602

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mkaput
Copy link
Contributor

@mkaput mkaput commented Nov 7, 2024

This is the proper location of this logic and utils modules should
be eradicated from existence.

This is the proper location of this logic and `utils` modules should
be eradicated from existence.
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @piotmag769)

Copy link
Collaborator

@Draggu Draggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @piotmag769)

@mkaput mkaput added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit d390b09 Nov 7, 2024
47 checks passed
@mkaput mkaput deleted the mkaput/methods branch November 7, 2024 11:29
@piotmag769 piotmag769 removed their request for review November 7, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants