Don't report diagnostics for missing types. #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liorgold2
force-pushed
the
pr/liorgold2/lior/missing/e85f35c0
branch
from
9901bf0
to
4d5db86
Compare
orizi
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
liorgold2
force-pushed
the
pr/liorgold2/lior/missing/e85f35c0
branch
from
4d5db86
to
1d06453
Compare
liorgold2
changed the base branch from
pr/liorgold2/lior/missing/2b4a4f25
to
main
commit-id:e85f35c0
liorgold2
force-pushed
the
pr/liorgold2/lior/missing/e85f35c0
branch
from
1d06453
to
2081b67
Compare
orizi
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is