Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix parity-scale-codec hint index #5985

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

dan-starkware
Copy link
Contributor

@dan-starkware dan-starkware commented Jul 9, 2024

This change is Reviewable

@dan-starkware dan-starkware requested a review from orizi July 9, 2024 14:51
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @dan-starkware)

a discussion (no related file):
so it would be in the next release - target dev-v2.7.0 instead.



crates/cairo-lang-casm/src/hints/mod.rs line 288 at r1 (raw file):

    },

    #[cfg_attr(feature = "parity-scale-codec", codec(index = 28))]

maybe just makes this the 29 - or is it already committed to 28 here?

Code quote:

    #[cfg_attr(feature = "parity-scale-codec", codec(index = 28))]

Copy link
Contributor Author

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @orizi)


crates/cairo-lang-casm/src/hints/mod.rs line 288 at r1 (raw file):

Previously, orizi wrote…

maybe just makes this the 29 - or is it already committed to 28 here?

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)

Copy link
Contributor Author

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

a discussion (no related file):

Previously, orizi wrote…

so it would be in the next release - target dev-v2.7.0 instead.

Done.


@dan-starkware dan-starkware changed the base branch from main to dev-v2.7.0 July 9, 2024 15:26
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@dan-starkware dan-starkware added this pull request to the merge queue Jul 9, 2024
@orizi orizi removed this pull request from the merge queue due to a manual request Jul 9, 2024
@dan-starkware dan-starkware added this pull request to the merge queue Jul 9, 2024
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)


-- commits line 1 at r2:
rebase and make sure you only have the single relevant commit.

@dan-starkware dan-starkware removed this pull request from the merge queue due to a manual request Jul 9, 2024
Copy link
Contributor Author

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


-- commits line 1 at r2:

Previously, orizi wrote…

rebase and make sure you only have the single relevant commit.

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@orizi orizi enabled auto-merge July 9, 2024 15:38
@orizi orizi added this pull request to the merge queue Jul 9, 2024
Merged via the queue into dev-v2.7.0 with commit b605db2 Jul 9, 2024
44 checks passed
@orizi orizi deleted the dan/hints/fix-codec branch July 11, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants