-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to include statements functions in artifacts from test compilation #5913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @maciektr and @piotmag769)
crates/cairo-lang-test-plugin/src/lib.rs
line 50 at r1 (raw file):
/// Configuration for test compilation. pub struct TestCompilationConfig { pub starknet: bool,
doc members.
crates/cairo-lang-test-plugin/src/lib.rs
line 58 at r1 (raw file):
/// # Arguments /// * `db` - Preloaded compilation database. /// * `starknet` - Add the starknet contracts to the compiled tests.
fix doc
Code quote:
/// * `starknet` - Add the starknet contracts to the compiled tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @maciektr and @orizi)
crates/cairo-lang-test-plugin/src/lib.rs
line 50 at r1 (raw file):
Previously, orizi wrote…
doc members.
Done.
crates/cairo-lang-test-plugin/src/lib.rs
line 58 at r1 (raw file):
Previously, orizi wrote…
fix doc
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @maciektr and @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @maciektr)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @piotmag769)
Needed for Scarb to be able to produce the mappings in test artifacts as well (for purposes of
cairo-profiler
).This change is