Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include statements functions in artifacts from test compilation #5913

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

piotmag769
Copy link
Collaborator

@piotmag769 piotmag769 commented Jun 28, 2024

Needed for Scarb to be able to produce the mappings in test artifacts as well (for purposes of cairo-profiler).


This change is Reviewable

@piotmag769 piotmag769 requested review from orizi and maciektr and removed request for orizi June 28, 2024 17:01
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @maciektr and @piotmag769)


crates/cairo-lang-test-plugin/src/lib.rs line 50 at r1 (raw file):

/// Configuration for test compilation.
pub struct TestCompilationConfig {
    pub starknet: bool,

doc members.


crates/cairo-lang-test-plugin/src/lib.rs line 58 at r1 (raw file):

/// # Arguments
/// * `db` - Preloaded compilation database.
/// * `starknet` - Add the starknet contracts to the compiled tests.

fix doc

Code quote:

/// * `starknet` - Add the starknet contracts to the compiled tests.

Copy link
Collaborator Author

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @maciektr and @orizi)


crates/cairo-lang-test-plugin/src/lib.rs line 50 at r1 (raw file):

Previously, orizi wrote…

doc members.

Done.


crates/cairo-lang-test-plugin/src/lib.rs line 58 at r1 (raw file):

Previously, orizi wrote…

fix doc

Done.

Copy link
Collaborator Author

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @maciektr and @orizi)

@piotmag769 piotmag769 requested a review from orizi July 1, 2024 08:34
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @maciektr)

Copy link
Collaborator

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @piotmag769)

@piotmag769 piotmag769 added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 1266e61 Jul 1, 2024
44 checks passed
@orizi orizi deleted the statements-functions-in-test-compilation branch July 1, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants