Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS: Run Cairo formatter over item signatures in hover #5822

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

mkaput
Copy link
Contributor

@mkaput mkaput commented Jun 18, 2024

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkaput)


crates/cairo-lang-language-server/src/lang/inspect/defs.rs line 266 at r1 (raw file):

// Run Cairo formatter over code with extra post-processing that is specific to signatures.
fn fmt(code: String) -> String {

Suggestion:

/// Run Cairo formatter over code with extra post-processing that is specific to signatures.
fn fmt(code: String) -> String {

Base automatically changed from spr/main/8a0befe3 to main June 19, 2024 09:17
Copy link
Contributor Author

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-language-server/src/lang/inspect/defs.rs line 266 at r1 (raw file):

// Run Cairo formatter over code with extra post-processing that is specific to signatures.
fn fmt(code: String) -> String {

Done.

@mkaput mkaput enabled auto-merge June 19, 2024 09:18
@mkaput mkaput added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 4646ad8 Jun 19, 2024
84 of 85 checks passed
@mkaput mkaput deleted the spr/main/3ec25feb branch June 19, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants