Updated bounded_int_constrain to allow constraining NonZero of ranges. #5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2024
ilyalesokhin-starkware
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
orizi
force-pushed
the
pr/orizi/misc/170bf0ef
branch
from
ce4451a
to
c5ca564
Compare
orizi
force-pushed
the
pr/orizi/misc/82788c8d
branch
2 times, most recently
from
6a6d737
to
6c72fc3
Compare
orizi
force-pushed
the
pr/orizi/misc/170bf0ef
branch
from
c5ca564
to
c7cbba2
Compare
orizi
force-pushed
the
pr/orizi/misc/82788c8d
branch
from
6c72fc3
to
faa7f12
Compare
orizi
force-pushed
the
pr/orizi/misc/170bf0ef
branch
from
c7cbba2
to
78dd1b9
Compare
ilyalesokhin-starkware
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
orizi
force-pushed
the
pr/orizi/misc/82788c8d
branch
from
faa7f12
to
7bd5840
Compare
orizi
force-pushed
the
pr/orizi/misc/170bf0ef
branch
2 times, most recently
from
db8aa7f
to
8399abd
Compare
orizi
force-pushed
the
pr/orizi/misc/82788c8d
branch
from
7bd5840
to
7e2ec0c
Compare
ilyalesokhin-starkware
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
commit-id:82788c8d
orizi
force-pushed
the
pr/orizi/misc/82788c8d
branch
from
7e2ec0c
to
84f2a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
This change is