Added multi-pop for span.

[orizi]

Stack:

• Using multi-pop in sha256 impl. #5590
• Added high level support and tests for multi pops. #5589
• Added multi-pop for span. #5588 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-sierra/src/extensions/modules/array.rs line 633 at r1 (raw file):

                                        ty,
                                        count
                                            .to_usize()

why usize here an i16 in the implementation?

Code quote:

                                        count
                                            .to_usize()

[ilyalesokhin-starkware]

crates/cairo-lang-sierra/src/extensions/modules/utils.rs line 116 at r1 (raw file):

/// Returns a fixed type array of the given type and size.
pub fn fixed_array_ty(

Suggestion:

fixed_size_array_ty

[ilyalesokhin-starkware]

crates/cairo-lang-sierra-to-casm/src/invocations/array.rs line 391 at r1 (raw file):

        deref arr_end;
    };
    let popped_size: i16 = libfunc.popped_values * element_size;

why i16?

Code quote:

i16

[ilyalesokhin-starkware]

Reviewed 7 of 10 files at r1, all commit messages.
Reviewable status: 7 of 10 files reviewed, 5 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-sierra-to-casm/src/invocations/array.rs line 448 at r1 (raw file):

    );
    casm_build_extend! {casm_builder,
        const popped_size = popped_size;

Suggestion:

 // Success case
 const popped_size = popped_size;

---

crates/cairo-lang-sierra-to-casm/src/invocations/array.rs line 486 at r1 (raw file):

        tempvar minus_length = arr_start - arr_end;
        tempvar rc = minus_length + popped_size_plus_1;
        assert rc = *(range_check++);

Why is the negative case
popped_size_plus_1 >= array_length?

shouldn't it be
array_length < popped_size
?

Suggestion:

        /// Prove that popped_size_plus_1 >= array_length        
        tempvar minus_length = arr_start - arr_end;
        tempvar rc = minus_length + popped_size_plus_1;
        assert rc = *(range_check++);

[orizi]

Reviewable status: 4 of 10 files reviewed, 5 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra/src/extensions/modules/array.rs line 633 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

why usize here an i16 in the implementation?

it is for being repeated - but changing to i16.

---

crates/cairo-lang-sierra/src/extensions/modules/utils.rs line 116 at r1 (raw file):

/// Returns a fixed type array of the given type and size.
pub fn fixed_array_ty(

Done.

---

crates/cairo-lang-sierra-to-casm/src/invocations/array.rs line 448 at r1 (raw file):

    );
    casm_build_extend! {casm_builder,
        const popped_size = popped_size;

Done.

[orizi]

Reviewable status: 4 of 10 files reviewed, 5 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra-to-casm/src/invocations/array.rs line 391 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

why i16?

since this is the bound for actual type sizes.

[orizi]

Reviewable status: 4 of 10 files reviewed, 5 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra-to-casm/src/invocations/array.rs line 486 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Why is the negative case
popped_size_plus_1 >= array_length?

shouldn't it be
array_length < popped_size
?

Done.

[ilyalesokhin-starkware]

crates/cairo-lang-sierra-to-casm/src/invocations/array.rs line 487 at r2 (raw file):

        jump HasEnoughElements if has_enough_elements != 0;
        // Proving that `arr_start - arr_end + popped_size + 1 >= 0` and therefore
        // `popped_size + 1 >= arr_end - arr_end == arr.len()` ==> `arr.len() < popopped_size`.

Suggestion:

`popped_size + 1 >= arr_end - arr_start

[ilyalesokhin-starkware]

Reviewed 2 of 10 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

[orizi]

Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra-to-casm/src/invocations/array.rs line 487 at r2 (raw file):

        jump HasEnoughElements if has_enough_elements != 0;
        // Proving that `arr_start - arr_end + popped_size + 1 >= 0` and therefore
        // `popped_size + 1 >= arr_end - arr_end == arr.len()` ==> `arr.len() < popopped_size`.

Done.