-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid panics in print!
and format!
macros when missing parens
#5470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @orizi)
crates/cairo-lang-semantic/src/expr/test_data/inline_macros
line 640 at r1 (raw file):
// Missing parens. print!;
FYI This was panicking the compiler to date.
5c2a863
to
3a547a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @mkaput)
crates/cairo-lang-semantic/src/inline_macros/print.rs
line 77 at r1 (raw file):
"args".to_string(), arguments.arg_list(db).map_or_else(RewriteNode::empty, |n| { RewriteNode::new_trimmed(n.as_syntax_node())
do the same for format
.
commit-id:d79a9241
print!
macro family when missing parensprint!
and format!
macros when missing parens
3a547a1
to
cc9751e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-semantic/src/inline_macros/print.rs
line 77 at r1 (raw file):
Previously, orizi wrote…
do the same for
format
.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)
This change is