Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed loop inside loop issue. #5441

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fixed loop inside loop issue. #5441

merged 1 commit into from
Apr 18, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Apr 18, 2024

Closes #5438


This change is Reviewable

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-lowering/src/lower/mod.rs line 319 at r1 (raw file):

) -> Maybe<FlatLowered> {
    let mut ctx = LoweringContext::new(encapsulating_ctx, function_id, loop_signature.clone())?;
    let old = std::mem::replace(&mut ctx.current_loop_expr_id, Some(loop_expr_id));

Suggestion:

old_loop_expr_id

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit 5959ff1 Apr 18, 2024
43 checks passed
@orizi orizi deleted the orizi/fix-loop-in-loop branch April 21, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation Bug: itertools: .zip_eq() reached end of one iterator before the other
2 participants