Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): code action for unused variable #5214

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

0xLucqs
Copy link
Contributor

@0xLucqs 0xLucqs commented Mar 7, 2024

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @LucasLvy and @mkaput)


crates/cairo-lang-diagnostics/src/error_code.rs line 76 at r1 (raw file):

pub mod codes {
    /// Unused variable
    pub const UNUSED_VARIABLE: &str = "E0001";

Suggestion:

pub mod codes {
    /// Unused variable.
    pub const UNUSED_VARIABLE: &str = "E0001";

Copy link
Contributor Author

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @mkaput and @orizi)


crates/cairo-lang-diagnostics/src/error_code.rs line 76 at r1 (raw file):

pub mod codes {
    /// Unused variable
    pub const UNUSED_VARIABLE: &str = "E0001";

Done.

@0xLucqs 0xLucqs requested a review from orizi March 7, 2024 15:34
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

@0xLucqs 0xLucqs added this pull request to the merge queue Mar 7, 2024
Merged via the queue into starkware-libs:main with commit 0651c0a Mar 7, 2024
43 checks passed
mkaput added a commit that referenced this pull request Mar 8, 2024
mkaput added a commit that referenced this pull request Mar 8, 2024
mkaput added a commit that referenced this pull request Mar 8, 2024
mkaput added a commit that referenced this pull request Mar 8, 2024
mkaput added a commit that referenced this pull request Mar 11, 2024
mkaput added a commit that referenced this pull request Mar 11, 2024
shramee pushed a commit to shramee/cairo that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants