-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lsp): code action for unused variable #5214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @LucasLvy and @mkaput)
crates/cairo-lang-diagnostics/src/error_code.rs
line 76 at r1 (raw file):
pub mod codes { /// Unused variable pub const UNUSED_VARIABLE: &str = "E0001";
Suggestion:
pub mod codes {
/// Unused variable.
pub const UNUSED_VARIABLE: &str = "E0001";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @mkaput and @orizi)
crates/cairo-lang-diagnostics/src/error_code.rs
line 76 at r1 (raw file):
pub mod codes { /// Unused variable pub const UNUSED_VARIABLE: &str = "E0001";
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)
This change is