Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings and lints #5030

Merged
merged 4 commits into from
Feb 14, 2024
Merged

fix warnings and lints #5030

merged 4 commits into from
Feb 14, 2024

Conversation

thor314
Copy link
Contributor

@thor314 thor314 commented Feb 7, 2024

Fixes a few lints and warnings.

  • cargo clippy --fix
  • ? operator
  • lint by hand

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @thor314)


crates/cairo-lang-sierra-ap-change/src/compute.rs line 40 at r1 (raw file):

enum ApTrackingBase {
    FunctionStart(FunctionId),
    #[allow(dead_code)]

why is it deadcode for you?

Code quote:

    #[allow(dead_code)]

@thor314
Copy link
Contributor Author

thor314 commented Feb 8, 2024

@orizi
clippy flags the enum variant as unused. This indicates that the enum variant is not directly consumed. A grep for the variant shows that it's used in one place, so this warning may be a linting bug, rather than a bug in the library. I can comment it as such if helpful.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @thor314)

a discussion (no related file):
@gilbens-starkware for 2nd eye


Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @thor314)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @thor314)

@orizi orizi added this pull request to the merge queue Feb 14, 2024
Merged via the queue into starkware-libs:main with commit cd2a2ef Feb 14, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants