-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for underscore pattern in match on tuples #4996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)
crates/cairo-lang-lowering/src/lower/lower_match.rs
line 105 at r1 (raw file):
))); }; //
I believe some push was missed.
Code quote:
//
a979a71
to
b0e2fc9
Compare
55d1327
to
89470e2
Compare
b0e2fc9
to
1720363
Compare
89470e2
to
3d2aea2
Compare
1720363
to
e96ebf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-lowering/src/lower/lower_match.rs
line 105 at r1 (raw file):
Previously, orizi wrote…
I believe some push was missed.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)
crates/cairo-lang-lowering/src/test_data/match
line 1510 at r2 (raw file):
(true,true) => 1, _ => 2 }
Suggestion:
fn foo() -> felt252 {
match (true, false) {
(true, true) => 1,
_ => 2
}
30ab4e5
to
52fe6b8
Compare
e96ebf6
to
1145d2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)
1145d2b
to
5c3e72c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
493f264
to
3044bc5
Compare
5c3e72c
to
2f62f97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
2f62f97
to
356f7c4
Compare
This change is