-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache node children. #4247
Cache node children. #4247
Conversation
I've tried removing this function in a single PR. Code quote: pub fn children<'db>(&self, db: &'db dyn SyntaxGroup) -> SyntaxNodeChildIterator<'db> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-syntax/src/node/db.rs
line 20 at r1 (raw file):
fn intern_stable_ptr(&self, field: SyntaxStablePtr) -> SyntaxStablePtrId; fn get_children(&self, node: SyntaxNode) -> Arc<Vec<SyntaxNode>>;
doc
5b76235
to
7286f0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-syntax/src/node/db.rs
line 20 at r1 (raw file):
Previously, orizi wrote…
doc
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-syntax/src/node/db.rs
line 20 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Done.
Three ///
7286f0a
to
d9163d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-syntax/src/node/db.rs
line 20 at r1 (raw file):
Previously, orizi wrote…
Three ///
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
This change is