If available_gas is missing on tests it now has a default large value.

[orizi]

Also enabled static value to the param for cases we wish to specifically allow no dynamic gas intake.

---

This change is 

[yuvalsw]

Reviewed 31 of 32 files at r1, all commit messages.
Reviewable status: 31 of 32 files reviewed, 5 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-test-plugin/src/test_config.rs line 11 at r1 (raw file):

use super::{AVAILABLE_GAS_ATTR, IGNORE_ATTR, SHOULD_PANIC_ATTR, TEST_ATTR};
use crate::STATIC_GAS_ARG;

merge the 2 lines.

Code quote:

use super::{AVAILABLE_GAS_ATTR, IGNORE_ATTR, SHOULD_PANIC_ATTR, TEST_ATTR};
use crate::STATIC_GAS_ARG;

---

crates/cairo-lang-test-plugin/src/test_config.rs line 121 at r1 (raw file):

}

/// Extract the available gas from the attribute.

Suggestion:

 Extracts the available 

---

crates/cairo-lang-test-plugin/src/test_config.rs line 138 at r1 (raw file):

                ..
            },
        ] => literal.numeric_value(db).unwrap_or_default().to_usize(),

why unwrap_or_default and not '?'?

Code quote:

unwrap_or_default()

---

crates/cairo-lang-test-plugin/src/test_config.rs line 149 at r1 (raw file):

                stable_ptr: attr.id_stable_ptr.untyped(),
                message: format!(
                    "Attribute should have a single value argument or `{STATIC_GAS_ARG}`."

We don't support short strings here.

Suggestion:

single numeric literal argumen

---

crates/cairo-lang-test-runner/src/test_config.rs line 0 at r1 (raw file):
why is this file deleted?

[orizi]

Reviewable status: 31 of 32 files reviewed, 2 unresolved discussions (waiting on @yuvalsw)

---

crates/cairo-lang-test-plugin/src/test_config.rs line 138 at r1 (raw file):

Previously, yuvalsw wrote…

why unwrap_or_default and not '?'?

adding all this to the same diagnostic instead.

---

crates/cairo-lang-test-runner/src/test_config.rs line at r1 (raw file):

Previously, yuvalsw wrote…

why is this file deleted?

because it was duplicated - it is an old duplication of the other test_config.rs

[yuvalsw]

Reviewed 1 of 32 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-test-plugin/src/test_config.rs line 122 at r2 (raw file):

/// Extract the available gas from the attribute.
/// Adds a diagnostic if the attribute is malformed.
/// Returns `None` if the attribute is `static`, or the attribute is malformed.

Suggestion:

e is "static", or

---

crates/cairo-lang-test-plugin/src/test_config.rs line 137 at r2 (raw file):

            stable_ptr: attr.args_stable_ptr.untyped(),
            message: format!(
                "Attribute should have a single value argument or `{STATIC_GAS_ARG}`."

numeric literal

Code quote:

 a single value argument 

---

crates/cairo-lang-test-plugin/src/test_config.rs line 141 at r2 (raw file):

        })
    };
    match &attr.args[..] {

consider returning a bool from this match and then if true, add the diagnostic. Otherwise, in most cases the lambda is created but not used.

[orizi]

Reviewable status: 31 of 32 files reviewed, 2 unresolved discussions (waiting on @yuvalsw)

---

crates/cairo-lang-test-plugin/src/test_config.rs line 137 at r2 (raw file):

Previously, yuvalsw wrote…

numeric literal

Done.

---

crates/cairo-lang-test-plugin/src/test_config.rs line 141 at r2 (raw file):

Previously, yuvalsw wrote…

consider returning a bool from this match and then if true, add the diagnostic. Otherwise, in most cases the lambda is created but not used.

doesn't look nicer unfortunately - rather have this.

[yuvalsw]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-test-plugin/src/test_config.rs line 141 at r2 (raw file):

Previously, orizi wrote…

doesn't look nicer unfortunately - rather have this.

doesn't look nicer - maybe, but more efficient in the good (common) case.

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yuvalsw)

---

crates/cairo-lang-test-plugin/src/test_config.rs line 141 at r2 (raw file):

Previously, yuvalsw wrote…

doesn't look nicer - maybe, but more efficient in the good (common) case.

the closure created and not being used is very unlikely to have an actual cost.

[yuvalsw]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-test-plugin/src/test_config.rs line 141 at r2 (raw file):

Previously, orizi wrote…

the closure created and not being used is very unlikely to have an actual cost.

I still think it's better and don't see the big advantage of this approach, but not insisting - unblocking.