Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

test: test segment arena number of instances #2087

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware commented Jul 15, 2024

This change is Reviewable

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)


crates/blockifier/src/execution/entry_point_test.rs line 537 at r1 (raw file):

        entry_point_call.execute_directly(&mut state).unwrap().resources.builtin_instance_counter
            [&BuiltinName::segment_arena],
        2

what does this number represent?

Code quote:

2

crates/blockifier/src/execution/entry_point_test.rs line 538 at r1 (raw file):

            [&BuiltinName::segment_arena],
        2
    );

safer... don't want line breaks to remove this for the error preview. non blocking

Suggestion:

    assert_eq!(
        entry_point_call.execute_directly(&mut state).unwrap().resources.builtin_instance_counter
            [&BuiltinName::segment_arena],
        // Note: the number of segment_arena instances should not depend on the compiler or VM
        // version. Do not manually fix this then when upgrading them - it might be a bug.
        2
    );

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

@Yoni-Starkware Yoni-Starkware merged commit 4bebcb7 into main-v0.13.2 Jul 15, 2024
11 checks passed
@Yoni-Starkware Yoni-Starkware deleted the yoni/test/segment-arena branch July 15, 2024 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants