This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Elin/merge main v0.13.1 into main #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- validate invocation had a syntax error, which was hidden by the cfg - remove `testing` from the cfg, since we all compile with `testing` during development, and it's just not what we want. Co-Authored-By: Gilad Chase <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
+ Coverage 69.50% 69.99% +0.49%
==========================================
Files 59 59
Lines 8220 8221 +1
Branches 8220 8221 +1
==========================================
+ Hits 5713 5754 +41
+ Misses 2044 2002 -42
- Partials 463 465 +2 ☔ View full report in Codecov by Sentry. |
barak-b-starkware
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is