test(execution): get_sequencer_address in test_validate_accounts_tx

[ArniStarkware]

This change is 

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffb7f6f) 69.44% compared to head (0ed14fb) 69.44%.

Additional details and impacted files

@@              Coverage Diff              @@
##           main-v0.13.1    #1496   +/-   ##
=============================================
  Coverage         69.44%   69.44%           
=============================================
  Files                59       59           
  Lines              8127     8127           
  Branches           8127     8127           
=============================================
  Hits               5644     5644           
  Misses             2024     2024           
  Partials            459      459           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ArniStarkware]

crates/blockifier/feature_contracts/cairo0/account_faulty.cairo line 29 at r2 (raw file):

// const GET_BLOCK_TIMESTAMP = 6;
// Use get_sequencer_address syscall.
const GET_SEQUENCER_ADDRESS = 7;

Please delete these unused lines.

Suggestion:

// Use get_sequencer_address syscall.
const GET_SEQUENCER_ADDRESS = 7;

[aner-starkware]

crates/blockifier/feature_contracts/cairo0/account_faulty.cairo line 29 at r2 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Please delete these unused lines.

Should I add a TODO?

[ArniStarkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @aner-starkware, @MohammadNassar1, @noaov1, and @TzahiTaub)

---

crates/blockifier/feature_contracts/cairo0/account_faulty.cairo line 29 at r2 (raw file):

Previously, aner-starkware wrote…

Should I add a TODO?

Yes please, but not here. See the comment below.

---

crates/blockifier/src/transaction/transactions_test.rs line 1485 at r3 (raw file):

        account_tx.execute(state, block_context, true, true).unwrap();
    }

Please add a TODO:
// TODO(): Cover positive flows of Cairo 0 syscalls: get_block_number and get_block_timestamp.

[MohammadNassar1]

Reviewed 1 of 1 files at r3, 1 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware, @noaov1, and @TzahiTaub)

The base branch was changed.

[ArniStarkware]

crates/blockifier/src/transaction/transactions_test.rs line 1440 at r5 (raw file):

    }
    if let CairoVersion::Cairo0 = cairo_version {
        // Trying to use the syscall get_sequencer_address (forbidden).

Suggestion:

       // Try to use the syscall get_sequencer_address (forbidden).

[aner-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @TzahiTaub)

[ArniStarkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @TzahiTaub)

[MohammadNassar1]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @TzahiTaub)

[aner-starkware]

crates/blockifier/src/transaction/transactions_test.rs line 1440 at r5 (raw file):

    }
    if let CairoVersion::Cairo0 = cairo_version {
        // Trying to use the syscall get_sequencer_address (forbidden).

OK, will fix next PR