This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
refacto: state traits take all their args by value #1264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions with @giladchase about #1232 I split part of the changes into this PR that presents no functional changes and will therefore be easier to review and merge.
the traits' methods signatures were weird. Most args were passed by value but some were by reference. All of those imp Copy, so let's pass them all by value
for some reason, the
set_storage_at
method was declared infallible. Which we can't know for sure.This change is