Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add migration to V6 #943

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

PhilippeR26
Copy link
Collaborator

Motivation and Resolution

In the frame of Starknet.js v6 pre-release, added in the migration guide the recommendations to migrate from v5 to v6.

Usage related changes

Changed the start page : migration guide from v5

Development related changes

Do not forget to create a last V5 documentation variant, before the pre-release.

Checklist:

  • Rebased to the last commit of the target branch (or merged it into my branch)

@ivpavici
Copy link
Collaborator

@penovicp is it okay here to target the beta branch? I think we want this doc to only be part of the v6 version

Copy link
Collaborator

@ivpavici ivpavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Account Class TransactionVersion V3 setup and note it works only with RPC 0.6+.
Default is v2 that works with 0.5+

This is not a breaking change but it is important for one to use v3 tx, so not sure should it be added here.

Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we cover all but good starting point.

@tabaktoni tabaktoni merged commit 1ff1986 into starknet-io:beta Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

🎉 This PR is included in version 6.0.0-beta.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Feb 5, 2024

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jul 3, 2024

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants