Fix Rpc 0.2.1 v1 Transaction and Edpoint #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for starknetjs canceled.
|
tabaktoni
commented
Nov 21, 2022
| @@ -242,7 +242,7 @@ export class RpcProvider implements ProviderInterface { | |||
| return this.fetchEndpoint('starknet_estimateFee', { | |||
| request: { | |||
| type: 'INVOKE', | |||
| contract_address: invocation.contractAddress, | |||
| sender_address: invocation.contractAddress, | |||
There was a problem hiding this comment.
Note that the entry parameter is contractAddress but used as sender_address.
This is left to be like this because of Sequencer.
penovicp
approved these changes
Nov 21, 2022
ivpavici
approved these changes
Nov 21, 2022
dhruvkelawala
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Infura does not use rpc/v0.2 endpoint, so we restored to open entry for node RPC
The issue raised from Telegram/Slack
RPC version (if applicable)
0.2.1
Usage related changes
Checklist: