-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export abi types #1145
fix: export abi types #1145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that rpc spec 0.6 is identical to rpc spec 0.7 about contract types.
In this case, for any src/utils code , is it better to use the internal rpcspec_06, or to use the rpcspec 0.7 of the types-js library?
Yea, abi didn't change, I would recommend using rpcspec 0.7 as it is the latest one, and 0.6 will be deprecated at some point. I updated this one for convenience. |
So, you should also add exports to these functions in the types-js lib (I have seen you commit this), and publish in npm. |
Yes it is added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me
Motivation and Resolution
...
RPC version (if applicable)
...
Usage related changes
Development related changes
Checklist: