Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export abi types #1145

Merged
merged 3 commits into from
Jun 5, 2024
Merged

fix: export abi types #1145

merged 3 commits into from
Jun 5, 2024

Conversation

tabaktoni
Copy link
Collaborator

Motivation and Resolution

...

RPC version (if applicable)

...

Usage related changes

  • Change 1.
  • ...

Development related changes

  • Change 1.
  • ...

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@tabaktoni tabaktoni requested review from penovicp and PhilippeR26 June 5, 2024 14:57
Copy link
Collaborator

@PhilippeR26 PhilippeR26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that rpc spec 0.6 is identical to rpc spec 0.7 about contract types.
In this case, for any src/utils code , is it better to use the internal rpcspec_06, or to use the rpcspec 0.7 of the types-js library?

@tabaktoni
Copy link
Collaborator Author

tabaktoni commented Jun 5, 2024

Seems that rpc spec 0.6 is identical to rpc spec 0.7 about contract types. In this case, for any src/utils code , is it better to use the internal rpcspec_06, or to use the rpcspec 0.7 of the types-js library?

Yea, abi didn't change, I would recommend using rpcspec 0.7 as it is the latest one, and 0.6 will be deprecated at some point. I updated this one for convenience.

@tabaktoni tabaktoni changed the base branch from develop to next-version June 5, 2024 15:51
@PhilippeR26
Copy link
Collaborator

PhilippeR26 commented Jun 5, 2024

So, you should also add exports to these functions in the types-js lib (I have seen you commit this), and publish in npm.

@tabaktoni tabaktoni requested review from ivpavici and PhilippeR26 June 5, 2024 15:54
@tabaktoni
Copy link
Collaborator Author

So, you should also add exports to these functions in the types-js lib.

Yes it is added

Copy link
Collaborator

@PhilippeR26 PhilippeR26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

@tabaktoni tabaktoni merged commit 38cc55f into next-version Jun 5, 2024
3 checks passed
@penovicp penovicp deleted the fix/export-abi-types branch June 21, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants