Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Start adding types #1

Merged
merged 16 commits into from
Oct 19, 2021
Merged

Feature: Start adding types #1

merged 16 commits into from
Oct 19, 2021

Conversation

janek26
Copy link
Member

@janek26 janek26 commented Oct 19, 2021 •
edited
Loading

Hey!

Thanks for starting this project, I hope I can contribute a bit in the coming days!

In this PR I started adding proper types to the method returns, so it's easier to work with for the developers.

I didnt quite get how TSDoc works, and I'd be super grateful if you could add the return types into the doc generation!
I also automated the build/test process as well as the docs generation, so it stays consistent (see .github/workflows/node.js.yml)

you can see checks passing here:
argentlabs#1

janek26
janek26 commented Oct 19, 2021
View reviewed changes
docs/README.md Show resolved Hide resolved
@0xs34n 0xs34n merged commit 4694086 into starknet-io:main Oct 19, 2021
janek26 pushed a commit that referenced this pull request Jun 20, 2022
@Arcticae
Merge pull request #1 from 0xs34n/pr/232
8a51962 
test: gateway error
ivpavici pushed a commit that referenced this pull request Aug 24, 2022
@envusr
Merge pull request #1 from ExoMonk/develop
12ebdb7 
0.3.0 Events and Block fetching
@yoga-braavos yoga-braavos mentioned this pull request Dec 21, 2022
Merged
7 tasks
tabaktoni pushed a commit that referenced this pull request Jul 6, 2023
@PhilippeR26
feat: add Enum in contract
515e233 
Squashed commit of the following:

commit fd6064e
Author: Philippe ROSTAN <[email protected]>
Date:   Mon Jul 3 19:26:54 2023 +0200

    feat: merge in hellocairo2

commit 0246933
Author: Philippe ROSTAN <[email protected]>
Date:   Mon Jul 3 17:21:45 2023 +0200

    feat: merge v5.16.0
    Squashed commit of the following:

    commit e5696b4
    Author: semantic-release-bot <[email protected]>
    Date:   Mon Jul 3 15:08:31 2023 +0000

        chore(release): 5.16.0 [skip ci]

        * cairo1 version2 support ([e564033](e564033))
        * extract parser from CallData and Cairo ([b7eba2a](b7eba2a))
        * parsers ([cce9029](cce9029))

    commit 3389085
    Merge: e6b861a 589c948
    Author: Toni Tabak <[email protected]>
    Date:   Mon Jul 3 17:06:08 2023 +0200

        Merge pull request #670 from 0xs34n/next-version

        Next version

    commit 589c948
    Merge: ffa6d07 03ee060
    Author: Toni Tabak <[email protected]>
    Date:   Mon Jul 3 16:38:23 2023 +0200

        Merge pull request #665 from 0xs34n/0.12.0/abi-parser

        abi parser Cario1 Version2

    commit 03ee060
    Author: Toni Tabak <[email protected]>
    Date:   Mon Jul 3 16:32:11 2023 +0200

        chore: cleanup

    commit 6c0eae2
    Author: Toni Tabak <[email protected]>
    Date:   Mon Jul 3 14:07:45 2023 +0200

        chore: compiled files

    commit e564033
    Author: Toni Tabak <[email protected]>
    Date:   Mon Jul 3 14:05:52 2023 +0200

        feat: cairo1 version2 support

    commit ffa6d07
    Merge: e6b861a 6f8164f
    Author: Toni Tabak <[email protected]>
    Date:   Mon Jul 3 11:43:42 2023 +0200

        Merge pull request #664 from amanusk/cairo_v2_example

        Add example of new synatx cairo contract

    commit cae5abd
    Author: Toni Tabak <[email protected]>
    Date:   Mon Jul 3 11:41:51 2023 +0200

        chore: refact

    commit cce9029
    Author: Toni Tabak <[email protected]>
    Date:   Fri Jun 30 16:16:21 2023 +0200

        feat: parsers

    commit b7eba2a
    Author: Toni Tabak <[email protected]>
    Date:   Fri Jun 30 16:13:14 2023 +0200

        feat: extract parser from CallData and Cairo

    commit 6f8164f
    Author: amanusk <[email protected]>
    Date:   Thu Jun 29 21:23:28 2023 +0300

        Add example of new synatx cairo contract

commit 15c1dcc
Author: Philippe ROSTAN <[email protected]>
Date:   Sun Jul 2 14:36:05 2023 +0200

    feat: sierra.json with enums

commit 7e6e136
Merge: b2e7a40 e6b861a
Author: Philippe ROSTAN <[email protected]>
Date:   Fri Jun 30 12:36:18 2023 +0200

    Merge pull request #1 from 0xs34n/develop

    merge
tabaktoni pushed a commit that referenced this pull request Jul 18, 2023
@PhilippeR26
feat: calldata result in populate
d44dc56 
Squashed commit of the following:

commit f7fd920
Author: Philippe ROSTAN <[email protected]>
Date:   Tue Jul 11 16:35:42 2023 +0200

    feat: meta-class accepts Calldata as input

commit b2e6c29
Author: Philippe ROSTAN <[email protected]>
Date:   Tue Jul 11 11:14:47 2023 +0200

    fix: calldata relocated

commit 045af8e
Author: CI <[email protected]>
Date:   Wed Jul 5 06:52:47 2023 +0000

    docs: generate documentation

commit 5f308d4
Author: Ivan Pavičić <[email protected]>
Date:   Wed Jul 5 08:48:29 2023 +0200

    docs: added waitForTransaction section and cleanups (#675)

    * docs: added waitForTransaction section and cleanups

    * docs: grammarly

    ---------

    Co-authored-by: Toni Tabak <[email protected]>

commit da64857
Author: semantic-release-bot <[email protected]>
Date:   Mon Jul 3 15:08:31 2023 +0000

    chore(release): 5.16.0 [skip ci]

    * cairo1 version2 support ([e564033](e564033))
    * extract parser from CallData and Cairo ([b7eba2a](b7eba2a))
    * parsers ([cce9029](cce9029))

commit ff35d5f
Author: Toni Tabak <[email protected]>
Date:   Mon Jul 3 16:32:11 2023 +0200

    chore: cleanup

commit 92b2be5
Author: Toni Tabak <[email protected]>
Date:   Mon Jul 3 14:07:45 2023 +0200

    chore: compiled files

commit 1f365f8
Author: Toni Tabak <[email protected]>
Date:   Mon Jul 3 14:05:52 2023 +0200

    feat: cairo1 version2 support

commit 5cdfdeb
Author: Toni Tabak <[email protected]>
Date:   Mon Jul 3 11:41:51 2023 +0200

    chore: refact

commit 3af53bd
Author: Toni Tabak <[email protected]>
Date:   Fri Jun 30 16:16:21 2023 +0200

    feat: parsers

commit 6e25aac
Author: Toni Tabak <[email protected]>
Date:   Fri Jun 30 16:13:14 2023 +0200

    feat: extract parser from CallData and Cairo

commit 2cb2848
Author: amanusk <[email protected]>
Date:   Thu Jun 29 21:23:28 2023 +0300

    Add example of new synatx cairo contract

commit 7e6e136
Merge: b2e7a40 e6b861a
Author: Philippe ROSTAN <[email protected]>
Date:   Fri Jun 30 12:36:18 2023 +0200

    Merge pull request #1 from 0xs34n/develop

    merge
github-actions bot pushed a commit that referenced this pull request Jul 18, 2023
@semantic-release-bot
chore(release): 5.17.0 [skip ci]
384db9f 
# [5.17.0](v5.16.0...v5.17.0) (2023-07-18)

### Bug Fixes

* add FailedTransactionResponse ([994925e](994925e))
* remedy type declaration roll-up issues ([48625f4](48625f4))
* transaction_failure_reason ([77329b7](77329b7))

### Features

* add Enum in contract ([515e233](515e233)), closes [#670](#670) [#665](#665) [#664](#664) [#1](#1)
* calldata result in populate ([d44dc56](d44dc56)), closes [#675](#675) [#1](#1)
* contractFactory Cairo1 & changed constructor signature, 0.12 test fixes ([9b44c54](9b44c54))
* rename Failed to Rejected for transaction type ([65b1ef4](65b1ef4))
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@semantic-release-bot
chore(release): 5.19.0 [skip ci]
2da6658 
# [5.19.0](v5.18.0...v5.19.0) (2023-08-11)

### Bug Fixes

* add function definition to the contract interface + doc ([06498d5](06498d5))
* contract test status ([53cfaf9](53cfaf9))
* fix multiple same events + add cairo code + seperate tests, legacy and Cairo1 ([7c93157](7c93157))
* modify parseEvents structure + add testcase for multiple different event in same tx ([b63b0d6](b63b0d6))
* optional struct and enum in responseParser ([14d3cca](14d3cca))
* patch merge, and add enums to event parser ([00f8073](00f8073))
* remove exports from responseParser functions ([3d86446](3d86446))
* repair SequencerProvider network resolution ([e42dfc1](e42dfc1))
* restore package-lock to previous state ([2fe0564](2fe0564))

### Features

* add ethAddress handling ([2a93f90](2a93f90))
* cairo enum in request parser ([ad44481](ad44481))
* cairo enum in response parser ([a936a11](a936a11)), closes [#670](#670) [#665](#665) [#664](#664) [#1](#1) [#675](#675) [#1](#1) [#675](#675) [#1](#1) [#670](#670) [#665](#665) [#664](#664) [#1](#1) [#675](#675) [#1](#1)
* implement event parsing ([86cc430](86cc430))
* new Cairo types ([f9db09e](f9db09e))
@mianshenglee mianshenglee mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janek26 @0xs34n