Merge pull request #201 from badurinantun/get-storage-at-key

Change "getStorageAt" key type
starknet-io · Jun 7, 2022 · 80a5aba · 80a5aba
2 parents b2ba2f8 + b8c60a9
commit 80a5aba
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 4 deletions.
diff --git a/__tests__/provider.test.ts b/__tests__/provider.test.ts
@@ -1,4 +1,5 @@
 import { defaultProvider, stark } from '../src';
+import { toBN } from '../src/utils/number';
 import { compiledArgentAccount } from './fixtures';
 
 const { compileCalldata } = stark;
@@ -42,7 +43,7 @@ describe('defaultProvider', () => {
         )
       ).resolves.not.toThrow();
     });
-    test('getStorageAt()', () => {
+    test('getStorageAt() with "key" type of number', () => {
       return expect(
         defaultProvider.getStorageAt(
           '0x01d1f307c073bb786a66e6e042ec2a9bdc385a3373bb3738d95b966d5ce56166',
@@ -51,6 +52,24 @@ describe('defaultProvider', () => {
         )
       ).resolves.not.toThrow();
     });
+    test('getStorageAt() with "key" type of string', () => {
+      return expect(
+        defaultProvider.getStorageAt(
+          '0x01d1f307c073bb786a66e6e042ec2a9bdc385a3373bb3738d95b966d5ce56166',
+          '0',
+          36663
+        )
+      ).resolves.not.toThrow();
+    });
+    test('getStorageAt() with "key" type of BN', () => {
+      return expect(
+        defaultProvider.getStorageAt(
+          '0x01d1f307c073bb786a66e6e042ec2a9bdc385a3373bb3738d95b966d5ce56166',
+          toBN('0x0'),
+          36663
+        )
+      ).resolves.not.toThrow();
+    });
     test('getStorageAt(blockHash=undefined, blockNumber=null)', () => {
       return expect(
         defaultProvider.getStorageAt(

diff --git a/src/provider/default.ts b/src/provider/default.ts
@@ -250,7 +250,7 @@ export class Provider implements ProviderInterface {
    */
   public async getStorageAt(
     contractAddress: string,
-    key: number,
+    key: BigNumberish,
     blockIdentifier: BlockIdentifier = 'pending'
   ): Promise<object> {
     return this.fetchEndpoint('get_storage_at', { blockIdentifier, contractAddress, key });

diff --git a/src/provider/interface.ts b/src/provider/interface.ts
@@ -85,7 +85,7 @@ export abstract class ProviderInterface {
    */
   public abstract getStorageAt(
     contractAddress: string,
-    key: number,
+    key: BigNumberish,
     blockIdentifier?: BlockIdentifier
   ): Promise<object>;
 

diff --git a/src/types/api.ts b/src/types/api.ts
@@ -55,7 +55,7 @@ export type Endpoints = {
   get_storage_at: {
     QUERY: {
       contractAddress: string;
-      key: number;
+      key: BigNumberish;
       blockIdentifier: BlockIdentifier;
     };
     REQUEST: never;