chore!: remove the chain id property from the provider interface

__tests__/rpcProvider.test.ts

@@ -23,7 +23,7 @@ describeIfRpc('RPCProvider', () => {
 
   test('getChainId', async () => {
     const fetchSpy = jest.spyOn(rpcProvider as any, 'fetchEndpoint');
-    rpcProvider.chainId = undefined as unknown as StarknetChainId;
+    (rpcProvider as any).chainId = undefined as unknown as StarknetChainId;
     const chainId1 = await rpcProvider.getChainId();
     const chainId2 = await rpcProvider.getChainId();
     expect(fetchSpy.mock.calls.length).toBe(1);

src/provider/default.ts

@@ -53,10 +53,6 @@ export class Provider implements ProviderInterface {
     }
   }
 
-  public get chainId(): StarknetChainId {
-    return this.provider.chainId;
-  }
-
   public async getChainId(): Promise<StarknetChainId> {
     return this.provider.getChainId();
   }

src/provider/interface.ts

@@ -22,8 +22,6 @@ import type { BigNumberish } from '../utils/number';
 import { BlockIdentifier } from './utils';
 
 export abstract class ProviderInterface {
-  public abstract chainId: StarknetChainId;
-
   /**
    * Gets the Starknet chain Id
    *

src/provider/rpc.ts

@@ -43,11 +43,10 @@ const defaultOptions = {
 export class RpcProvider implements ProviderInterface {
   public nodeUrl: string;
 
-  // TODO: consider making private
-  public chainId!: StarknetChainId;
-
   public headers: object;
 
+  private chainId!: StarknetChainId;
+
   private responseParser = new RPCResponseParser();
 
   private retries: number;

src/provider/sequencer.ts

@@ -81,10 +81,10 @@ export class SequencerProvider implements ProviderInterface {
 
   public gatewayUrl: string;
 
-  public chainId: StarknetChainId;
-
   public headers: object | undefined;
 
+  private chainId: StarknetChainId;
+
   private responseParser = new SequencerAPIResponseParser();
 
   private blockIdentifier: BlockIdentifier;