fix: provider

starknet-io · Jul 15, 2022 · 32f9072 · 32f9072
1 parent 2c08e5d
commit 32f9072
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -11,7 +11,6 @@ jobs:
 
     env:
       TEST_PROVIDER_BASE_URL: http://127.0.0.1:5050/
-      TEST_RPC_URL: ${{ secrets.TEST_RPC_URL }}
     services:
       devnet:
         image: janek2601/starknet-devnet-patched

diff --git a/src/account/default.ts b/src/account/default.ts
@@ -1,5 +1,5 @@
 import { ZERO } from '../constants';
-import { ProviderOptions } from '../provider';
+import { ProviderInterface, ProviderOptions } from '../provider';
 import { Provider } from '../provider/default';
 import { Signer, SignerInterface } from '../signer';
 import {
@@ -23,7 +23,7 @@ export class Account extends Provider implements AccountInterface {
   public signer: SignerInterface;
 
   constructor(
-    providerOrOptions: ProviderOptions | Provider,
+    providerOrOptions: ProviderOptions | ProviderInterface,
     public address: string,
     keyPairOrSigner: KeyPair | SignerInterface
   ) {

diff --git a/src/contract/default.ts b/src/contract/default.ts
@@ -578,6 +578,7 @@ export class Contract implements ContractInterface {
       });
     }
 
+    // eslint-disable-next-line no-console
     console.warn(`Invoking ${method} without an account. This will not work on a public node.`);
 
     return this.providerOrAccount.invokeFunction({

diff --git a/src/utils/number.ts b/src/utils/number.ts
@@ -10,6 +10,10 @@ export function isHex(hex: string): boolean {
 }
 
 export function toBN(number: BigNumberish, base?: number | 'hex') {
+  if (typeof number === 'string') {
+    // eslint-disable-next-line no-param-reassign
+    number = number.toLowerCase();
+  }
   if (typeof number === 'string' && isHex(number) && !base)
     return new BN(removeHexPrefix(number), 'hex');
   return new BN(number, base);