Skip to content

Commit

Permalink
fix: cleanup pr.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
dhruvkelawala committed Sep 19, 2022
1 parent 51c9482 commit 263e296
Showing 1 changed file with 2 additions and 26 deletions.
28 changes: 2 additions & 26 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,29 +19,8 @@ jobs:
- run: npm ci
- run: npm run build --if-present

- uses: actions/upload-artifact@v2
with:
name: build
path: dist

tests:
strategy:
max-parallel: 1 # needed until we get a seperate account for the rpc provider, until then running them in parallel would result in a nonce issue
matrix:
name: [sequencer-test, sequencer-goerli, rpc-goerli]
include:
- name: sequencer-test
TEST_PROVIDER_BASE_URL: http://127.0.0.1:5050/
- name: sequencer-goerli
TEST_PROVIDER_BASE_URL: https://alpha4.starknet.io
ENABLE_TEST_ACCOUNT_PRIVATE_KEY: true
ENABLE_TEST_ACCOUNT_ADDRESS: true
- name: rpc-goerli
ENABLE_TEST_RPC_URL: true
ENABLE_TEST_ACCOUNT_PRIVATE_KEY: true
ENABLE_TEST_ACCOUNT_ADDRESS: true

name: Run test on ${{ matrix.name }}
name: Run test
runs-on: ubuntu-latest
needs: [build]

Expand All @@ -51,10 +30,7 @@ jobs:
ports:
- 5050:5050
env:
TEST_PROVIDER_BASE_URL: ${{ matrix.TEST_PROVIDER_BASE_URL }}
TEST_RPC_URL: ${{ matrix.ENABLE_TEST_RPC_URL && secrets.TEST_RPC_URL }}
TEST_ACCOUNT_PRIVATE_KEY: ${{ matrix.ENABLE_TEST_ACCOUNT_PRIVATE_KEY && secrets.TEST_ACCOUNT_PRIVATE_KEY }}
TEST_ACCOUNT_ADDRESS: ${{ matrix.ENABLE_TEST_ACCOUNT_ADDRESS && secrets.TEST_ACCOUNT_ADDRESS }}
TEST_PROVIDER_BASE_URL: http://127.0.0.1:5050/

steps:
- uses: actions/checkout@v2
Expand Down

0 comments on commit 263e296

Please sign in to comment.