feat: update maxFee logic

starknet-io · Oct 10, 2022 · 19add10 · 19add10
1 parent a1f3b38
commit 19add10
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/account/default.ts b/src/account/default.ts
@@ -134,7 +134,7 @@ export class Account extends Provider implements AccountInterface {
     const transactions = Array.isArray(calls) ? calls : [calls];
     const nonce = toBN(transactionsDetail.nonce ?? (await this.getNonce()));
     let maxFee: BigNumberish = ZERO;
-    if (transactionsDetail.maxFee || transactionsDetail.maxFee === 0) {
+    if (transactionsDetail.maxFee) {
       maxFee = transactionsDetail.maxFee;
     } else {
       const { suggestedMaxFee } = await this.estimateInvokeFee(transactions, { nonce });
@@ -171,9 +171,9 @@ export class Account extends Provider implements AccountInterface {
     transactionsDetail: InvocationsDetails = {}
   ): Promise<DeclareContractResponse> {
     const nonce = toBN(transactionsDetail.nonce ?? (await this.getNonce()));
-    let maxFee: BigNumberish = '0';
+    let maxFee: BigNumberish = ZERO;
 
-    if (transactionsDetail.maxFee || transactionsDetail.maxFee === 0) {
+    if (transactionsDetail.maxFee) {
       maxFee = transactionsDetail.maxFee;
     } else {
       const { suggestedMaxFee } = await this.estimateDeclareFee(