Refactor ecdsa structure to suit starkbank's pattern #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavier-stark
force-pushed
the
refactor/ecdsa-structure
branch
from
6ccee2e to
b1963e5
Compare
xavier-stark
force-pushed
the
refactor/ecdsa-structure
branch
from
b1963e5 to
8a612a3
Compare
xavier-stark
force-pushed
the
refactor/ecdsa-structure
branch
from
8a612a3 to
dc9182b
Compare
| @@ -69,9 +79,9 @@ public static boolean verify(String message, Signature signature, PublicKey publ | |||
| return false; | |||
| } | |||
|
|
|||
| BigInteger w = Math.inv(s, curve.N); | |||
There was a problem hiding this comment.
linha 69 BigInteger.ONE
| this(curve, RandomInteger.between(BigInteger.ONE, curve.N.subtract(BigInteger.ONE))); | ||
| } | ||
|
|
||
| public PrivateKey(BigInteger secret) { |
There was a problem hiding this comment.
acho que faltou a docstring em cima desses dois métodos
| Object[] publicKeyStringObject = (Object[]) parsedObject1[1]; | ||
| String publicKeyString = publicKeyStringObject[0].toString().toLowerCase(); | ||
| if(privateKeyFlag != 1){ | ||
| throw new Exception("Private keys should start with a '1' flag, but a " + privateKeyFlag + " was found instead"); | ||
| } |
There was a problem hiding this comment.
acho que valem uns newlines aqui e ali pra separar melhor os blocos lógicos
| return publicKey; | ||
| } | ||
| if (p.isAtInfinity()) { | ||
| if(p.isAtInfinity()){ | ||
| throw new RuntimeException("Public Key point is at infinity"); | ||
| } | ||
| if (!curve.contains(p)) { |
There was a problem hiding this comment.
melhor padronizar se vai ser if() ou if () pra todo mundo logo
| ); | ||
| } | ||
|
|
||
| public static Signature _fromString(String string, BigInteger recoveryId) throws Exception { |
There was a problem hiding this comment.
pq _fromString em vez de fromString? Não faz mais sentido deixar private logo?
jumkey
reviewed
Mar 8, 2023
| s = ((numberMessage.add(r.multiply(privateKey.secret))).multiply(Math.inv(randNum, curve.N))).mod(curve.N); | ||
| } | ||
| BigInteger recoveryId = randomSignPoint.y.and(BigInteger.ONE); | ||
| if (randomSignPoint.y.compareTo(curve.N) > 0){ |
There was a problem hiding this comment.
randomSignPoint.x.compareTo(curve.N) > 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.