Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

fix(Accordion): close content when it contains nested children and the title is closed #108

Merged
merged 2 commits into from
Jul 19, 2018
Merged

fix(Accordion): close content when it contains nested children and the title is closed #108

merged 2 commits into from
Jul 19, 2018

Conversation

alinais
Copy link
Collaborator

@alinais alinais commented Jul 18, 2018 •
edited
Loading

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

@alinais alinais changed the title fix the accordion content to collapse when it contains nested children fix: close the accordion content when it contains nested children and the title is closed Jul 18, 2018
@codecov
Copy link

codecov bot commented Jul 18, 2018 •
edited
Loading

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   69.94%   69.94%           
=======================================
  Files          74       74           
  Lines        1198     1198           
  Branches      227      205   -22     
=======================================
  Hits          838      838           
  Misses        355      355           
  Partials        5        5
Impacted Files Coverage Δ
src/components/Accordion/Accordion.tsx 59.52% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d144c6...48a51b5. Read the comment docs.

@alinais alinais force-pushed the bug/accordion-doesnt-hide-jsx-content-when-closed branch from 307b698 to 12f3c80 Compare July 18, 2018 13:53
@kuzhelov kuzhelov changed the title fix: close the accordion content when it contains nested children and the title is closed fix(Accordion): close content when it contains nested children and the title is closed Jul 18, 2018
@alinais alinais force-pushed the bug/accordion-doesnt-hide-jsx-content-when-closed branch from 12f3c80 to 48a51b5 Compare July 19, 2018 12:36
@alinais alinais requested a review from dvdzkwsk as a code owner July 19, 2018 12:36
mnajdova
mnajdova approved these changes Jul 19, 2018
View reviewed changes
Copy link
Collaborator

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bug, so according to me it is good to be merged!

@alinais alinais merged commit 2b07c29 into master Jul 19, 2018
@alinais alinais deleted the bug/accordion-doesnt-hide-jsx-content-when-closed branch July 19, 2018 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@kuzhelov kuzhelov Awaiting requested review from kuzhelov kuzhelov is a code owner

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alinais @mnajdova