Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block executor optimize tps testsuite #3995

Open
wants to merge 90 commits into
base: master
Choose a base branch
from

Conversation

welbon
Copy link
Contributor

@welbon welbon commented Nov 28, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@@ -3,7 +3,7 @@ on:
workflow_dispatch:
pull_request:
branches:
- master
- block_executor_optimize_tps_validate

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里面的都的恢复吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -9,7 +9,7 @@
// JellyfishMerkleTree,
// };
// use anyhow::Result;
// use diem_crypto::HashValue;
// use starcoin_crypto::HashValue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这文件可以不修改吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件删出吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #3995 (9bdfa87) into master (2436a7a) will increase coverage by 0.15%.
Report is 3 commits behind head on master.
The diff coverage is 95.42%.

❗ Current head 9bdfa87 differs from pull request most recent head f9d5203. Consider uploading reports for the commit f9d5203 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3995      +/-   ##
==========================================
+ Coverage   54.49%   54.64%   +0.15%     
==========================================
  Files         640      641       +1     
  Lines       70090    70806     +716     
==========================================
+ Hits        38186    38682     +496     
- Misses      31904    32124     +220     
Flag Coverage Δ
unittests 54.64% <95.42%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
consensus/cryptonight-rs/src/lib.rs 100.00% <100.00%> (ø)
consensus/cryptonight-rs/src/tests.rs 78.73% <100.00%> (+5.04%) ⬆️
consensus/src/consensus_test.rs 100.00% <100.00%> (ø)
executor/src/block_executor.rs 88.24% <ø> (ø)
vm/block-executor/src/errors.rs 100.00% <100.00%> (ø)
vm/block-executor/src/executor.rs 99.25% <100.00%> (ø)
vm/block-executor/src/lib.rs 100.00% <ø> (ø)
vm/block-executor/src/txn_last_input_output.rs 97.12% <100.00%> (ø)
vm/block-executor/src/proptest_types/types.rs 91.88% <98.74%> (ø)
vm/block-executor/src/proptest_types/bencher.rs 0.00% <0.00%> (ø)
... and 4 more

... and 41 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45f98f...f9d5203. Read the comment docs.

- name: run fmt check
uses: actions-rs/cargo@v1
with:
command: fmt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件恢复原来吧

@@ -23,7 +23,7 @@ spec:
starcoin/node-pool: seed-pool
containers:
- name: starcoin
image: ghcr.io/starcoin/starcoin:v1.13.7
image: ghcr.io/starcoin/starcoin:v1.13.8
imagePullPolicy: Always
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要rebase下master

publish = { workspace = true }
version = "1.13.4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这需要rebase下master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants