Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve on dao #2947

Merged
merged 3 commits into from
Oct 13, 2021
Merged

improve on dao #2947

merged 3 commits into from
Oct 13, 2021

Conversation

nanne007
Copy link
Member

close #2925

@nanne007 nanne007 requested a review from jolestar October 12, 2021 02:25
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #2947 (42b38ab) into master (83e4e9d) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
- Coverage   33.46%   33.30%   -0.16%     
==========================================
  Files         517      517              
  Lines       45123    45123              
  Branches    20565    20566       +1     
==========================================
- Hits        15098    15024      -74     
- Misses      15841    15941     +100     
+ Partials    14184    14158      -26     
Flag Coverage Δ
unittests 33.30% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/types/src/account_config/events/config_change.rs 66.67% <0.00%> (-33.33%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
test-helper/src/dummy_network_service.rs 22.23% <0.00%> (-14.81%) ⬇️
executor/src/block_executor.rs 24.45% <0.00%> (-8.88%) ⬇️
vm/natives/src/account.rs 21.43% <0.00%> (-7.14%) ⬇️
cmd/starcoin/src/cli_state.rs 47.37% <0.00%> (-5.26%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 44.66% <0.00%> (-4.19%) ⬇️
cmd/starcoin/src/dev/tests.rs 14.44% <0.00%> (-4.12%) ⬇️
commons/accumulator/src/tree.rs 57.57% <0.00%> (-3.90%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e4e9d...42b38ab. Read the comment docs.

@nanne007 nanne007 merged commit 973c26a into master Oct 13, 2021
@nanne007 nanne007 deleted the dao-update branch October 13, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stdlib]DAO improvements
2 participants