Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix functional test build with thirdparity modules #2875

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Conversation

nanne007
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #2875 (225dabd) into master (e30fb9e) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
+ Coverage   31.28%   31.54%   +0.26%     
==========================================
  Files         512      512              
  Lines       45435    45220     -215     
  Branches    20489    20396      -93     
==========================================
+ Hits        14210    14259      +49     
+ Misses      17036    16811     -225     
+ Partials    14189    14150      -39     
Flag Coverage Δ
unittests 31.54% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/client/src/remote_state_reader.rs 22.23% <0.00%> (-14.44%) ⬇️
sync/src/announcement/mod.rs 10.23% <0.00%> (-7.95%) ⬇️
network-rpc/core/src/lib.rs 23.53% <0.00%> (-5.88%) ⬇️
network-rpc/api/src/lib.rs 17.15% <0.00%> (-3.80%) ⬇️
executor/src/script_function_test.rs 8.14% <0.00%> (-3.48%) ⬇️
sync/src/verified_rpc_client.rs 14.86% <0.00%> (-3.46%) ⬇️
txpool/src/tx_pool_service_impl.rs 41.96% <0.00%> (-2.29%) ⬇️
commons/timeout-join-handler/src/lib.rs 40.43% <0.00%> (-2.12%) ⬇️
network-rpc/src/rpc.rs 16.03% <0.00%> (-1.92%) ⬇️
sync/src/tasks/mock.rs 44.76% <0.00%> (-1.65%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30fb9e...225dabd. Read the comment docs.

@nanne007 nanne007 requested a review from jolestar September 14, 2021 12:17
@jolestar jolestar merged commit 8598864 into master Sep 14, 2021
@jolestar jolestar deleted the fix/move-cli branch September 14, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants