Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix dry run output view and raise error when transaction of same sender in txpool #2623

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

jolestar
Copy link
Member

No description provided.

@jolestar jolestar requested review from nanne007 and welbon June 23, 2021 13:22
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #2623 (9d57701) into master (e48ca93) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2623      +/-   ##
==========================================
- Coverage   32.54%   32.52%   -0.01%     
==========================================
  Files         501      501              
  Lines       43123    43123              
  Branches    19257    19257              
==========================================
- Hits        14030    14022       -8     
+ Misses      15316    15296      -20     
- Partials    13777    13805      +28     
Flag Coverage Δ
unittests 32.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/cli_state.rs 47.37% <ø> (-5.26%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
cmd/starcoin/src/dev/tests.rs 14.88% <0.00%> (-4.15%) ⬇️
network-p2p/src/peer_info.rs 44.45% <0.00%> (-2.77%) ⬇️
network-p2p/src/request_responses.rs 30.96% <0.00%> (-1.91%) ⬇️
network/src/service_ref.rs 37.34% <0.00%> (-1.33%) ⬇️
...ync/src/block_connector/block_connector_service.rs 32.19% <0.00%> (-1.14%) ⬇️
rpc/api/src/types.rs 15.53% <0.00%> (-1.01%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48ca93...9d57701. Read the comment docs.

@github-actions
Copy link

Benchmark for b6419b8

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.5±0.09ms 2.5±0.15ms 0.00%
block_apply/block_apply_10 464.0±7.51ms 462.3±3.55ms +0.37%
block_apply/block_apply_1000 48.2±0.43s 48.0±0.63s +0.42%
get_with_proof/db_store 39.3±0.84µs 38.5±0.37µs +2.08%
get_with_proof/mem_store 32.3±0.35µs 31.6±0.22µs +2.22%
put_and_commit/db_store/1 1530.0±109.84µs 1519.6±90.30µs +0.68%
put_and_commit/db_store/10 2.7±0.43ms 2.7±0.44ms 0.00%
put_and_commit/db_store/100 9.7±1.20ms 9.8±1.63ms -1.02%
put_and_commit/db_store/5 2.2±0.37ms 2.1±0.24ms +4.76%
put_and_commit/db_store/50 6.0±1.17ms 6.0±1.14ms 0.00%
put_and_commit/mem_store/1 62.8±5.64µs 63.2±5.57µs -0.63%
put_and_commit/mem_store/10 586.2±49.00µs 590.3±47.66µs -0.69%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 296.9±24.71µs 298.3±25.61µs -0.47%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.06ms 2.9±0.09ms 0.00%
query_block/query_block_in(10)_times(1000) 29.5±0.73ms 29.7±0.73ms -0.67%
query_block/query_block_in(10)_times(10000) 293.5±4.10ms 294.5±6.50ms -0.34%
query_block/query_block_in(1000)_times(100) 915.0±2.93µs 918.3±6.59µs -0.36%
query_block/query_block_in(1000)_times(1000) 9.2±0.04ms 9.3±0.04ms -1.08%
query_block/query_block_in(1000)_times(10000) 91.5±0.44ms 91.8±0.33ms -0.33%
storage_transaction 59.0±3.14ms 57.9±3.25ms +1.90%
vm/transaction_execution/1 327.4±0.36ms 327.1±1.02ms +0.09%
vm/transaction_execution/10 106.8±0.29ms 106.9±0.64ms -0.09%
vm/transaction_execution/20 99.8±0.19ms 100.1±0.90ms -0.30%
vm/transaction_execution/5 129.0±0.27ms 129.4±1.13ms -0.31%
vm/transaction_execution/50 113.8±0.16ms 114.4±0.75ms -0.52%

@nanne007 nanne007 merged commit c0a193e into master Jun 24, 2021
@nanne007 nanne007 deleted the fix_dry_run branch June 24, 2021 00:54
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants