Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set SSL verification default to True #442

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Set SSL verification default to True #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Under the Hood-20241103-212520.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Under the Hood
body: Enable SSL verification by default
time: 2024-11-03T21:25:20.671327+08:00
custom:
Author: mdesmet
Issue: "441"
PR: "442"
16 changes: 8 additions & 8 deletions dbt/adapters/trino/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from dataclasses import dataclass, field
from datetime import date, datetime
from enum import Enum
from typing import Any, Dict, List, Optional
from typing import Any, Dict, List, Optional, Union

import sqlparse
import trino
Expand Down Expand Up @@ -99,7 +99,7 @@ class TrinoNoneCredentials(TrinoCredentials):
user: str
client_tags: Optional[List[str]] = None
roles: Optional[Dict[str, str]] = None
cert: Optional[str] = None
cert: Optional[Union[str, bool]] = True
http_scheme: HttpScheme = HttpScheme.HTTP
http_headers: Optional[Dict[str, str]] = None
session_properties: Dict[str, Any] = field(default_factory=dict)
Expand All @@ -124,7 +124,7 @@ class TrinoCertificateCredentials(TrinoCredentials):
user: Optional[str] = None
client_tags: Optional[List[str]] = None
roles: Optional[Dict[str, str]] = None
cert: Optional[str] = None
cert: Optional[Union[str, bool]] = True
http_headers: Optional[Dict[str, str]] = None
session_properties: Dict[str, Any] = field(default_factory=dict)
prepared_statements_enabled: bool = PREPARED_STATEMENTS_ENABLED_DEFAULT
Expand Down Expand Up @@ -154,7 +154,7 @@ class TrinoLdapCredentials(TrinoCredentials):
impersonation_user: Optional[str] = None
client_tags: Optional[List[str]] = None
roles: Optional[Dict[str, str]] = None
cert: Optional[str] = None
cert: Optional[Union[str, bool]] = True
http_headers: Optional[Dict[str, str]] = None
session_properties: Dict[str, Any] = field(default_factory=dict)
prepared_statements_enabled: bool = PREPARED_STATEMENTS_ENABLED_DEFAULT
Expand Down Expand Up @@ -185,7 +185,7 @@ class TrinoKerberosCredentials(TrinoCredentials):
krb5_config: Optional[str] = None
service_name: Optional[str] = "trino"
mutual_authentication: Optional[bool] = False
cert: Optional[str] = None
cert: Optional[Union[str, bool]] = True
http_headers: Optional[Dict[str, str]] = None
force_preemptive: Optional[bool] = False
hostname_override: Optional[str] = None
Expand Down Expand Up @@ -227,7 +227,7 @@ class TrinoJwtCredentials(TrinoCredentials):
user: Optional[str] = None
client_tags: Optional[List[str]] = None
roles: Optional[Dict[str, str]] = None
cert: Optional[str] = None
cert: Optional[Union[str, bool]] = True
http_headers: Optional[Dict[str, str]] = None
session_properties: Dict[str, Any] = field(default_factory=dict)
prepared_statements_enabled: bool = PREPARED_STATEMENTS_ENABLED_DEFAULT
Expand All @@ -253,7 +253,7 @@ class TrinoOauthCredentials(TrinoCredentials):
user: Optional[str] = None
client_tags: Optional[List[str]] = None
roles: Optional[Dict[str, str]] = None
cert: Optional[str] = None
cert: Optional[Union[str, bool]] = True
http_headers: Optional[Dict[str, str]] = None
session_properties: Dict[str, Any] = field(default_factory=dict)
prepared_statements_enabled: bool = PREPARED_STATEMENTS_ENABLED_DEFAULT
Expand Down Expand Up @@ -282,7 +282,7 @@ class TrinoOauthConsoleCredentials(TrinoCredentials):
user: Optional[str] = None
client_tags: Optional[List[str]] = None
roles: Optional[Dict[str, str]] = None
cert: Optional[str] = None
cert: Optional[Union[str, bool]] = True
http_headers: Optional[Dict[str, str]] = None
session_properties: Dict[str, Any] = field(default_factory=dict)
prepared_statements_enabled: bool = PREPARED_STATEMENTS_ENABLED_DEFAULT
Expand Down
18 changes: 18 additions & 0 deletions tests/functional/adapter/test_insecure_warnings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import warnings

import pytest
from dbt.tests.util import run_dbt
from urllib3.exceptions import InsecureRequestWarning


@pytest.mark.skip_profile("trino_starburst")
class TestInsecureWarnings:
def test_table_properties(self, project):
with warnings.catch_warnings(record=True) as w:
dbt_args = ["show", "--inline", "select 1"]
run_dbt(dbt_args)

# Check if not any InsecureRequestWarning was raised
assert not any(
issubclass(warning.category, InsecureRequestWarning) for warning in w
), "InsecureRequestWarning was not raised"
Loading