Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dbt-common and dbt-adapters package #390

Merged

Conversation

damian3031
Copy link
Member

Migrate to dbt-common and dbt-adapters package.
Prepare for 1.8.0b1 release.

@damian3031 damian3031 linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link
Contributor

@hovaesco hovaesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@@ -56,7 +56,7 @@ For Trino- and Starburst-specific configuration, you can refer to [Starburst (Tr
First 5 steps are ONLY relevant for bumping __minor__ version:
1. Create `1.x.latest` branch from the latest tag corresponding to current minor version, e.g. `git checkout -b 1.6.latest v1.6.2` (when bumping to 1.7). Push branch to remote. This branch will be used for potential backports.
2. Create new branch (Do not push below commits to `1.x.latest`). Add a new entry in `.changes/0.0.0.md` that points to the newly created latest branch.
3. Run `changie merge` to update `README.md`. Commit.
3. Run `changie merge` to update `README.md`. After that, remove changie files and folders related to current minor version. Commit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we doing these steps manually?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, yes. After decoupling from dbt-core this process would probably change anyway. Maybe then we could automate it or update version-bump workflow.

@damian3031 damian3031 force-pushed the damian/refactor-to-use-dbt-adapters-interface-layer branch from a8697eb to 437c99d Compare March 12, 2024 14:31
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@damian3031 damian3031 merged commit 06e6334 into master Mar 12, 2024
14 of 15 checks passed
@damian3031 damian3031 deleted the damian/refactor-to-use-dbt-adapters-interface-layer branch March 12, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to use dbt-adapters interface layer
2 participants