Fix materialized_views filters when listing relations #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/fix-materialized-views-filters-when-listing-relations-d429c0
branch
from
0589040
to
534becc
Compare
damian3031
approved these changes
Sep 27, 2023
Before the change, the `list_relations_without_caching` macro queried `system.metadata.materialized_views` with no effective filter on the catalog and schema name. In theory the Trino optimizer could figure out the effective predicate on the `system.metadata.materialized_views` table, but in practice it was not happening, and all materialized views from all catalogs where being pulled.
findepi
force-pushed
the
findepi/fix-materialized-views-filters-when-listing-relations-d429c0
branch
from
534becc
to
a0be1c4
Compare
hovaesco
approved these changes
Sep 28, 2023
findepi
deleted the
findepi/fix-materialized-views-filters-when-listing-relations-d429c0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before the change, the
list_relations_without_cachingmacro queriedsystem.metadata.materialized_viewswith no effective filter on the catalog and schema name. In theory the Trino optimizer could figure out the effective predicate on thesystem.metadata.materialized_viewstable, but in practice it was not happening, and all materialized views from all catalogs where being pulled.Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry