Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add materialized view materialization #260

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Add materialized view materialization #260

merged 1 commit into from
Mar 9, 2023

Conversation

damian3031
Copy link
Member

Add materialized view materialization

@damian3031 damian3031 requested a review from mdesmet March 7, 2023 09:30
@damian3031 damian3031 force-pushed the mv-materializaiton branch 2 times, most recently from 8054838 to b1b3f0d Compare March 7, 2023 10:19
mdesmet
mdesmet reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@mdesmet mdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general remark, please base yourself on to the experimental mv code from dbt.

dbt/include/trino/macros/materializations/materialized_view.sql Show resolved Hide resolved
dbt/include/trino/macros/materializations/materialized_view.sql Outdated Show resolved Hide resolved
@damian3031 damian3031 force-pushed the mv-materializaiton branch 2 times, most recently from 91ca038 to 0c61310 Compare March 8, 2023 09:13
@damian3031 damian3031 requested a review from mdesmet March 8, 2023 09:20
mdesmet
mdesmet reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@mdesmet mdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM. Some minor remarks about tests.

tests/functional/adapter/materialization/test_materialized_view.py Outdated Show resolved Hide resolved
tests/functional/adapter/materialization/test_materialized_view.py Outdated Show resolved Hide resolved
tests/functional/adapter/materialization/test_materialized_view.py Outdated Show resolved Hide resolved
tests/functional/adapter/materialization/test_materialized_view.py Outdated Show resolved Hide resolved
tests/functional/adapter/materialization/test_materialized_view.py Outdated Show resolved Hide resolved
tests/functional/adapter/materialization/test_materialized_view.py Outdated Show resolved Hide resolved
@damian3031 damian3031 requested a review from mdesmet March 8, 2023 12:08
mdesmet
mdesmet reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@mdesmet mdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add docs.

Additonal question, does this also support setting properties in the model definition?

dbt/include/trino/macros/materializations/materialized_view.sql Show resolved Hide resolved
@damian3031 damian3031 force-pushed the mv-materializaiton branch 2 times, most recently from e1c4cde to 373660b Compare March 8, 2023 15:24
mdesmet
mdesmet reviewed Mar 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
mdesmet
mdesmet reviewed Mar 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mdesmet mdesmet merged commit ca18195 into starburstdata:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdesmet mdesmet mdesmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damian3031 @mdesmet