Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): allow recovering project if project is deleted #3115

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (554441f) 82.83% compared to head (2d49b63) 73.44%.

Files Patch % Lines
...e/mlops/configuration/security/JwtTokenFilter.java 82.14% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3115      +/-   ##
============================================
- Coverage     82.83%   73.44%   -9.40%     
- Complexity     3184     3186       +2     
============================================
  Files           575      433     -142     
  Lines         32075    15644   -16431     
  Branches       1866     1809      -57     
============================================
- Hits          26570    11489   -15081     
+ Misses         4680     3329    -1351     
- Partials        825      826       +1     
Flag Coverage Δ
console ?
controller 73.44% <82.14%> (+0.02%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui added bug 🐛 Something isn't working controller 🏘️ labels Jan 8, 2024
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit a5da552 into star-whale:main Jan 8, 2024
17 checks passed
@jialeicui jialeicui deleted the fix-project-recover branch January 9, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants