Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): added code confirmation to automatic login to prevent accidental operations #3113

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

jialeicui
Copy link
Contributor

Description

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ce80aa) 82.68% compared to head (db3970e) 91.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3113      +/-   ##
============================================
+ Coverage     82.68%   91.77%   +9.09%     
============================================
  Files           575      142     -433     
  Lines         32062    16395   -15667     
  Branches       1865       61    -1804     
============================================
- Hits          26510    15047   -11463     
+ Misses         4726     1346    -3380     
+ Partials        826        2     -824     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller ?
standalone 92.03% <ø> (+0.21%) ⬆️
unittests 91.77% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut merged commit b7f24e9 into star-whale:main Jan 5, 2024
38 checks passed
@jialeicui jialeicui deleted the auto-login-confirm branch January 5, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants