Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support for reporting client events to server/cloud instance #3094

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Dec 20, 2023

Description

depends on: #3092

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added the enhancement ❤️ New feature or request label Dec 20, 2023
@tianweidut tianweidut self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4949eea) 82.63% compared to head (ef6e2aa) 91.88%.

Files Patch % Lines
client/starwhale/base/client/api/event.py 80.00% 3 Missing ⚠️
client/starwhale/core/model/model.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3094      +/-   ##
============================================
+ Coverage     82.63%   91.88%   +9.24%     
============================================
  Files           571      137     -434     
  Lines         31844    16126   -15718     
  Branches       1865        0    -1865     
============================================
- Hits          26315    14817   -11498     
+ Misses         4703     1309    -3394     
+ Partials        826        0     -826     
Flag Coverage Δ
console ?
controller ?
standalone 91.88% <96.85%> (+0.03%) ⬆️
unittests 91.88% <96.85%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut changed the title feat(clinet): support client event to server/cloud instance feat(client): support client event to server/cloud instance Dec 21, 2023
@tianweidut tianweidut added the e2e label Dec 21, 2023
@tianweidut tianweidut marked this pull request as ready for review December 21, 2023 08:13
@tianweidut tianweidut changed the title feat(client): support client event to server/cloud instance feat(client): support for reporting client events to server/cloud instance Dec 21, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit b7524b5 into star-whale:main Dec 24, 2023
43 checks passed
@tianweidut tianweidut deleted the enhance/events branch December 24, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants