Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP enhancement(controller): add type for step spec #3076

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Dec 12, 2023

Description

  1. add type for step
  2. fix enum serialization error

TODO list:

  1. add validation in ui
  2. add validation in server api

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the enhancement ❤️ New feature or request label Dec 12, 2023
@goldenxinxing goldenxinxing changed the title feat(controller): add type for step spec enhancement(controller): add type for step spec Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bca9510) 82.70% compared to head (5f84a58) 73.40%.
Report is 8 commits behind head on main.

Files Patch % Lines
...ain/java/ai/starwhale/mlops/api/JobController.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3076      +/-   ##
============================================
- Coverage     82.70%   73.40%   -9.30%     
+ Complexity     3211     3192      -19     
============================================
  Files           571      436     -135     
  Lines         31789    15866   -15923     
  Branches       1873     1873              
============================================
- Hits          26290    11647   -14643     
+ Misses         4677     3393    -1284     
- Partials        822      826       +4     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller 73.42% <66.66%> (-0.12%) ⬇️
standalone ?
unittests 72.09% <ø> (-19.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldenxinxing goldenxinxing marked this pull request as ready for review December 14, 2023 06:13
class StepType(Enum):
evaluation = 'EVALUATION'
fine_tune = 'FINE_TUNE'
serving = 'SERVING'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add plain or customized type for @handler annotation

@@ -105,6 +106,7 @@ def register(
require_dataset: bool = False,
built_in: bool = False,
fine_tune: FineTune | None = None,
typ: StepType | None = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mabe typo for type: StepType

@goldenxinxing goldenxinxing changed the title enhancement(controller): add type for step spec WIP enhancement(controller): add type for step spec Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants